Skip to content

Ext info implementation#56

Merged
dinosaure merged 3 commits intomirage:mainfrom
reynir:ext-info
May 5, 2023
Merged

Ext info implementation#56
dinosaure merged 3 commits intomirage:mainfrom
reynir:ext-info

Conversation

@reynir
Copy link
Member

@reynir reynir commented May 5, 2023

SSH2_MSG_EXT_INFO is a message type for communicating extensions. This PR implements parsing and serializing extension information messages. The server is as well extended to send the server-sig-algs extension with available signature algorithms. This is necessary for newer openssh clients that want to use RSA keys.

I am very open to changing the code as it was written somewhat in a hurry to get it working before a demo.

@hannesm
Copy link
Member

hannesm commented May 5, 2023

looks fine, requires ocaml 4.10 though (please add a lower bound)

@dinosaure dinosaure merged commit d9907a8 into mirage:main May 5, 2023
@dinosaure
Copy link
Member

Thanks!

@reynir reynir deleted the ext-info branch May 5, 2023 16:20
hannesm added a commit to hannesm/opam-repository that referenced this pull request Jun 19, 2023
CHANGES:

* FEATURE server: propagate window-change message (mirage/awa-ssh#55 @reynir)
* FEATURE server: implement ext-info and server-sig-algs extension (mirage/awa-ssh#56 @reynir)
* FEATURE server: support RFC 4419 (group key exchanges) and NIST ECDH key
  exchanges, and X25519 (mirage/awa-ssh#63 mirage/awa-ssh#67 @hannesm)
* FEATURE server: handle unknown public keys (instead of closing the connection,
  send a message back, allowing other public keys to be probeb) (mirage/awa-ssh#68 @reynir)
* BUGFIX server: fix rekey (avoid allocating lots of timeout tasks (mirage/awa-ssh#58 @reynir)
* BUGFIX server: filter advertised host key algorithms with used host key
  (mirage/awa-ssh#62 @hannesm)
* server: use logs instead of printf (mirage/awa-ssh#69 @hannesm)
* awa-lwt: drop package (unused, mirage/awa-ssh#61 @hannesm)
* drop Driver module, embed into awa_test_server.ml (mirage/awa-ssh#64 @hannesm)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants