Fixed [msg_channel_data] buffering and size issues.#78
Merged
reynir merged 4 commits intomirage:mainfrom Apr 10, 2025
Merged
Conversation
Before [msg_channel_eof] was sent without draining [channel.tosent] buffer. Also sending large amount of data using [msg_channel_data] was not possible since no [msg_channel_window_adjust] was issued. Now [Client.eof] flushes channel buffer. And [Client.outgoing_data] issues [msg_channel_window_adjust] before sending data.
Contributor
Author
|
PR addresses #77 issue. |
hannesm
reviewed
Apr 10, 2025
reynir
reviewed
Apr 10, 2025
Member
reynir
left a comment
reynir
left a comment
There was a problem hiding this comment.
Thanks! I think you made some good and important observations - that we should try to flush pending data before sending EOF. FWIW I think this is also an issue in the server code.
Member
|
@reynir said:
I agree, but in the |
Member
|
From my point of view, this is ready to merge. Thanks a lot. @reynir please merge if you're satisfied. |
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Apr 24, 2025
CHANGES: * Drain channel.tosent before sending msg_channel_eof (mirage/awa-ssh#78 @gravicappa) * Server: delay authentication to effectful layer - patches from banawa (mirage/awa-ssh#74 @reynir)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before [msg_channel_eof] was sent without draining [channel.tosent] buffer. Also sending large amount of data using [msg_channel_data] was not possible since no [msg_channel_window_adjust] was issued.
Now [Client.eof] flushes channel buffer. And [Client.outgoing_data] issues [msg_channel_window_adjust] before sending data.