Merged
Conversation
reynir
approved these changes
May 27, 2025
Member
reynir
left a comment
reynir
left a comment
There was a problem hiding this comment.
Thanks. Eventually, I'd like to push that stuff out of awa_mirage and into the user's code. Sorry for breaking your code!
Member
Author
|
Thank you @reynir , you didn't broke anything, I need to keep my code updated with recent releases ;) |
reynir
added a commit
to reynir/opam-repository
that referenced
this pull request
May 28, 2025
CHANGES: * Add `Server.close`, fix close message semantics (mirage/awa-ssh#79 @reynir, review @hannesm) * Add authentication information in `Server.auth_state` `Done _` constructor (mirage/awa-ssh#80 @reynir, review @hannesm) * Make `Awa_mirage.Auth.lookup_user` public as it were before mirage/awa-ssh#74 (mirage/awa-ssh#81 @palainp, review @reynir)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR wants to add the ability to check the presence of an existing user in the user database.
Before the Auth refactoring, I could call
Awa.Auth.lookup_user user db, but not anymore. With this PR I'm able to callAwa_mirage.Auth.lookup_useragain :)The other solution, if there is another path to check that, is to change my code, but I haven't figured out yet.
I don't know if, while I'm at it, I should also make verify public, so you can tell me :)
Best