Skip to content

Conversation

@syuilo
Copy link
Member

@syuilo syuilo commented Oct 30, 2025

What

ついでにImageEffector周りをリファクタリング

Why

Additional info (optional)

  • warermarkの実装も揃える
  • export uidefinition
  • imageeffector要らない可能性

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests
@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 11.04478% with 596 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.52%. Comparing base (a888f28) to head (7bb9d3d).

Files with missing lines Patch % Lines
...ontend/src/components/MkImageFrameEditorDialog.vue 0.47% 210 Missing ⚠️
...kages/frontend/src/utility/image-frame-renderer.ts 9.60% 160 Missing ⚠️
packages/frontend/src/composables/use-uploader.ts 2.40% 81 Missing ⚠️
...ontend/src/utility/image-effector/ImageEffector.ts 7.14% 52 Missing ⚠️
packages/frontend/src/pages/settings/drive.vue 0.00% 25 Missing ⚠️
...rontend/src/components/MkWatermarkEditorDialog.vue 0.00% 20 Missing ⚠️
packages/frontend/src/preferences/def.ts 25.00% 15 Missing ⚠️
...s/frontend/src/utility/image-effector/fxs/frame.ts 74.13% 15 Missing ⚠️
packages/frontend/src/utility/webgl.ts 10.00% 9 Missing ⚠️
.../frontend/src/components/MkImageEffectorDialog.vue 0.00% 6 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #16725       +/-   ##
============================================
- Coverage    45.86%   17.52%   -28.35%     
============================================
  Files         1781      881      -900     
  Lines       184646    82360   -102286     
  Branches      5514     1358     -4156     
============================================
- Hits         84695    14435    -70260     
+ Misses       99922    67918    -32004     
+ Partials        29        7       -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@kakkokari-gtyih
Copy link
Contributor

左にプレビュー・右にパラメーターという構造を採用ている画面が

  • Embed
  • Watermark
  • Effect
  • Exif Frame

と増えてきたので、大枠のレイアウトだけでも共通化できると良さそう

@kakkokari-gtyih
Copy link
Contributor

kakkokari-gtyih commented Nov 3, 2025

背景のストライプがアニメーション設定OFFの場合は止めるようにしないといけなさそう
(そもそも動いてる必要あるのか問題はある、そちらに目線が行って調整の時気が散りそう)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages/frontend Client side specific issue/PR

3 participants