This repository was archived by the owner on Jul 22, 2024. It is now read-only.
add hash:"string" tags support #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellh
reviewed
May 10, 2017
hashstructure.go
Outdated
| ) | ||
|
|
||
| var ( | ||
| ErrNotStringer = errors.New("field tag set to string, but struct does not implement fmt.Stringer") |
Owner
There was a problem hiding this comment.
I think we should include the field name in the error output otherwise this can be pretty vague.
mitchellh
suggested changes
May 10, 2017
Owner
mitchellh
left a comment
mitchellh
left a comment
There was a problem hiding this comment.
This looks really great. I requested one small change. I'd do it myself but don't have time at the moment. If you get to it I'll merge.
Great job! Thank you!
Contributor
Author
|
Updated! Thanks 💯 |
mitchellh
approved these changes
May 11, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for hashing things that implement
fmt.Stringervia an additional struct tag to maintain backwards compatibility. This is especially useful when you have structs that containtime.Timein them, as there are no exported fields in it.edit: this looks awfully similar in purpose to hashicorp/vault#2689