feat: add configurability which share links to present per post #1 #5233
Draft
cschwartz wants to merge 2 commits intommistakes:masterfrom
Draft
feat: add configurability which share links to present per post #1 #5233cschwartz wants to merge 2 commits intommistakes:masterfrom
cschwartz wants to merge 2 commits intommistakes:masterfrom
Conversation
This allows users to select (in _config.yml) via ```yaml share_on: x: true facebook: true linkedin: true bluesky: true ``` which social share links are displayed per post. Defaults are set to true, so that there should be no breakage for default installations. Happy to work with your requirements and make changes as needed :)
…e-links feat: add configurability which share links to present per post
Collaborator
|
This might not work as intended. Liquid documentation:
So an explicitly specified Test your code to show I'm wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an enhancement or feature.
Summary
This allows users to select (in _config.yml) via
which social share links are displayed per post.
Defaults are set to true, so that there should be no breakage for default installations.
Happy to work with your requirements and make changes as needed :)
Context
No, I was not sure if there is an issue category for feature requests.
If this is not something you want in this project, we can still close the PR.