fix: allow empty elicitation form data when all fields are optional

[bolinfest]

Summary

When all of the fields of the schema for an elicitation are optional, it should be possible to hit the Submit button (sending "accept") without filling in any of the fields. Prior to this change, this would fail in the UI with:

Validation Error: data should be object

Previously, in this case, generateDefaultValue() would produce undefined as the default value, but as of this change, it produces {} instead. The undefined would fail the check here:

inspector/client/src/components/ElicitationRequest.tsx

Lines 82 to 90 in dff91a8

	const ajv = new Ajv();
	const validate = ajv.compile(request.request.requestedSchema);
	const isValid = validate(formData);
	if (!isValid) {
	const errorMessage = ajv.errorsText(validate.errors);
	setValidationError(errorMessage);
	return;
	}

Now it passes.

Note: Inspector V2 is under development to address architectural and UX improvements. See CONTRIBUTING.md for information about V2 development.

Type of Change

• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Documentation update
• Refactoring (no functional changes)
• Test updates
• Build/CI improvements

Changes Made

Related Issues

Testing

• Tested in UI mode
• Tested in CLI mode
• Tested with STDIO transport
• Tested with SSE transport
• Tested with Streamable HTTP transport
• Added/updated automated tests
• Manual testing performed

Test Results and/or Instructions

Screenshots are encouraged to share your testing results for this change.

Checklist

• Code follows the style guidelines (ran npm run prettier-fix)
• Self-review completed
• Code is commented where necessary
• Documentation updated (README, comments, etc.)

Breaking Changes

Additional Context

[bolinfest]

I don't understand what happened: why did an action in an unrelated repo close this PR?

[bolinfest]

@olaservo added proposed tests

[bolinfest]

@cliffhall would you be willing to take a look?

[olaservo]

LGTM - I tested with this tool triggering an elicitation with all optional inputs, and also tested that elicitations in the latest everything server built from main still worked after this change.

[bolinfest]

Thanks so much @olaservo!