-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[template] support mimo-v2 template #7095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[template] support mimo-v2 template #7095
Conversation
Summary of ChangesHello @Jintao-Huang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces comprehensive support for the MiMo-V2 model template, encompassing both its Flash and Flash-Base versions. The changes involve updating core system constants, registering the new models with their specific architectures and tokenizer functions, and defining a dedicated ChatML template. Additionally, the documentation has been revised to reflect the availability of these new models, ensuring that users can easily discover and utilize them within the framework. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for the mimo-v2 template and models. The changes include updating constants, registering the new model and template, and adding them to the documentation. My review focuses on ensuring consistency and correctness in the documentation and template definitions. I've found a couple of minor issues in the documentation tables and a potential issue with the response_prefix in the new template.
| |[mistralai/Ministral-3-8B-Reasoning-2512](https://modelscope.cn/models/mistralai/Ministral-3-8B-Reasoning-2512)|mistral_2512_thinking|mistral_2512_thinking|transformers>=5.0.0.dev0, mistral-common>=1.8.6|✘|vision|[mistralai/Ministral-3-8B-Reasoning-2512](https://huggingface.co/mistralai/Ministral-3-8B-Reasoning-2512)| | ||
| |[mistralai/Ministral-3-14B-Reasoning-2512](https://modelscope.cn/models/mistralai/Ministral-3-14B-Reasoning-2512)|mistral_2512_thinking|mistral_2512_thinking|transformers>=5.0.0.dev0, mistral-common>=1.8.6|✘|vision|[mistralai/Ministral-3-14B-Reasoning-2512](https://huggingface.co/mistralai/Ministral-3-14B-Reasoning-2512)| | ||
| |[PaddlePaddle/PaddleOCR-VL](https://modelscope.cn/models/PaddlePaddle/PaddleOCR-VL)|paddle_ocr|paddle_ocr|-|✘|-|[PaddlePaddle/PaddleOCR-VL](https://huggingface.co/PaddlePaddle/PaddleOCR-VL)| | ||
| |[Tencent-Hunyuan/HunyuanOCR](https://modelscope.cn/models/Tencent-Hunyuan/HunyuanOCR)|hunyuan_ocr|hunyuan_ocr|transformers>=4.49.0|✘|-|[tencent/HunyuanOCR](https://huggingface.co/tencent/HunyuanOCR)| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Tags for HunyuanOCR was changed from vision to -. Since OCR is a vision-related task, it would be more accurate to keep the vision tag for better discoverability and consistency.
| |[Tencent-Hunyuan/HunyuanOCR](https://modelscope.cn/models/Tencent-Hunyuan/HunyuanOCR)|hunyuan_ocr|hunyuan_ocr|transformers>=4.49.0|✘|-|[tencent/HunyuanOCR](https://huggingface.co/tencent/HunyuanOCR)| | |
| |[Tencent-Hunyuan/HunyuanOCR](https://modelscope.cn/models/Tencent-Hunyuan/HunyuanOCR)|hunyuan_ocr|hunyuan_ocr|transformers>=4.49.0|✘|vision|[tencent/HunyuanOCR](https://huggingface.co/tencent/HunyuanOCR)| |
| |[mistralai/Ministral-3-8B-Reasoning-2512](https://modelscope.cn/models/mistralai/Ministral-3-8B-Reasoning-2512)|mistral_2512_thinking|mistral_2512_thinking|transformers>=5.0.0.dev0, mistral-common>=1.8.6|✘|vision|[mistralai/Ministral-3-8B-Reasoning-2512](https://huggingface.co/mistralai/Ministral-3-8B-Reasoning-2512)| | ||
| |[mistralai/Ministral-3-14B-Reasoning-2512](https://modelscope.cn/models/mistralai/Ministral-3-14B-Reasoning-2512)|mistral_2512_thinking|mistral_2512_thinking|transformers>=5.0.0.dev0, mistral-common>=1.8.6|✘|vision|[mistralai/Ministral-3-14B-Reasoning-2512](https://huggingface.co/mistralai/Ministral-3-14B-Reasoning-2512)| | ||
| |[PaddlePaddle/PaddleOCR-VL](https://modelscope.cn/models/PaddlePaddle/PaddleOCR-VL)|paddle_ocr|paddle_ocr|-|✘|-|[PaddlePaddle/PaddleOCR-VL](https://huggingface.co/PaddlePaddle/PaddleOCR-VL)| | ||
| |[Tencent-Hunyuan/HunyuanOCR](https://modelscope.cn/models/Tencent-Hunyuan/HunyuanOCR)|hunyuan_ocr|hunyuan_ocr|transformers>=4.49.0|✘|-|[tencent/HunyuanOCR](https://huggingface.co/tencent/HunyuanOCR)| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Tags for HunyuanOCR was changed from vision to -. Since OCR is a vision-related task, it would be more accurate to keep the vision tag for better discoverability and consistency.
| |[Tencent-Hunyuan/HunyuanOCR](https://modelscope.cn/models/Tencent-Hunyuan/HunyuanOCR)|hunyuan_ocr|hunyuan_ocr|transformers>=4.49.0|✘|-|[tencent/HunyuanOCR](https://huggingface.co/tencent/HunyuanOCR)| | |
| |[Tencent-Hunyuan/HunyuanOCR](https://modelscope.cn/models/Tencent-Hunyuan/HunyuanOCR)|hunyuan_ocr|hunyuan_ocr|transformers>=4.49.0|✘|vision|[tencent/HunyuanOCR](https://huggingface.co/tencent/HunyuanOCR)| |
| ChatmlTemplateMeta( | ||
| LLMTemplateType.mimo_v2, | ||
| default_system='You are MiMo, a helpful AI assistant engineered by Xiaomi.', | ||
| response_prefix='<think></think>', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The response_prefix is set to <think></think>, which is an empty tag pair. This is inconsistent with other "thinking" templates like ring2 and gpt_oss which use <think>\n to allow the model to generate thoughts. An empty tag might not be the intended behavior. If the model is not expected to generate thoughts, it might be better to use <think>\n</think>\n to represent an empty thinking step explicitly. If it is expected to generate thoughts, <think>\n would be more appropriate.
| response_prefix='<think></think>', | |
| response_prefix='<think>\n</think>\n', |
No description provided.