-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[megatron] support megatron fsdp #7117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @Jintao-Huang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces foundational support for Megatron FSDP, a technique designed to optimize memory usage and scalability in large-scale distributed training. It provides new configuration options that allow users to enable FSDP, choose between Megatron's implementation or PyTorch's FSDP2, and specify different sharding strategies for data parallelism. These changes are reflected in both the core argument definition and the user-facing documentation. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for Megatron FSDP by adding new command-line parameters and their corresponding fields in the MegatronArguments dataclass. The documentation has been updated in both Chinese and English, which is crucial for user understanding. The changes are well-aligned with the pull request's objective.
| use_megatron_fsdp: bool = False | ||
| use_torch_fsdp2: bool = False | ||
| data_parallel_sharding_strategy: Literal['no_shard', 'optim', 'optim_grads', 'optim_grads_params'] = 'no_shard' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good practice to add metadata={'help': '...'} to dataclass fields that represent command-line arguments. This makes the arguments self-documenting and improves clarity when generating help messages or inspecting the arguments programmatically. Please consider adding descriptive help strings for these new FSDP-related parameters.
| use_megatron_fsdp: bool = False | |
| use_torch_fsdp2: bool = False | |
| data_parallel_sharding_strategy: Literal['no_shard', 'optim', 'optim_grads', 'optim_grads_params'] = 'no_shard' | |
| use_megatron_fsdp: bool = field(default=False, metadata={'help': 'Use Megatron FSDP in DDP.'}) | |
| use_torch_fsdp2: bool = field(default=False, metadata={'help': 'Use torch FSDP2 implementation (recommend using `--use_megatron_fsdp` instead).'}) | |
| data_parallel_sharding_strategy: Literal['no_shard', 'optim', 'optim_grads', 'optim_grads_params'] = field(default='no_shard', metadata={'help': "Sharding strategy for data parallelism. Options are 'no_shard', 'optim', 'optim_grads', 'optim_grads_params'."}) |
No description provided.