fix: bound POSIX installer download stalls - #361
Open
paulcakeface wants to merge 6 commits into
Open
Conversation
Author
|
Bounty follow-up: the eligibility/product-use gap on linked issue #360 is now resolved and recorded there. This branch is still based on current upstream |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #360.
What changed
MONK_AGENT_DOWNLOAD_CONNECT_TIMEOUT(default 10s)MONK_AGENT_DOWNLOAD_STALL_TIMEOUT(default 30s)ensure-monk-agent.shcopies in syncWhy
The POSIX bootstrap previously delegated checksum/archive transfer duration entirely to curl/wget defaults. A server that accepts a connection but stops making progress can therefore hold plugin installation before the launcher reaches its separate readiness deadline.
This is distinct from #52 (post-launch readiness timeout) and #90 (offline fallback to a previously verified local agent).
Validation
sh -non the patched installer and regression scriptensure_monk_agent_download_timeout=pass calls=2mainat8d9a2c3e9b1fcf0ba185f010f9452b2162cd6b54I also prepared Install E2E workflow wiring locally, but did not include it because the connected GitHub token does not have permission to modify
.github/workflows/*on the fork. The regression itself is included and can be run directly with:Prepared with ChatGPT/Codex assistance.