Harden deploy verification for #346 (catch port black-hole + missing secrets) - #371
Open
NyxSpecter4 wants to merge 1 commit into
Open
Harden deploy verification for #346 (catch port black-hole + missing secrets)#371NyxSpecter4 wants to merge 1 commit into
NyxSpecter4 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #346
After a cluster lifecycle, new deploys report success while host-ports are black-holed and MANIFEST secrets resolve to null. The root cause lives in monkd (closed-source); this PR hardens the plugin-side verification so the agent catches the failure instead of green-washing it.
What changed (agents/monk-deployer.md, Verification section)
Scope / honesty
This is a detection and hardening fix on the agent-facing skill. It does not patch monkd lifecycle port/secret state (that remains an upstream platform issue). But it directly enforces azygoss's expectation in #346: a deploy must never report success while its published ports are unreachable from every source and its MANIFEST secrets were silently skipped.
Verification of the change
Happy to adjust wording or move the reference into skills/monk/references/ if maintainers prefer.