-
Notifications
You must be signed in to change notification settings - Fork 69
feat(core): Add config option to skip files considered for imports #140
Conversation
nadeesha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Almost there.
Could you add a test case to the integration tests as well?
Ah yeah, good call. I'll have a look at this in the week. Thanks for your comments, they all make sense to me 👍 |
Co-authored-by: Nadeesha Cabral <n@nadeesha.me>
|
@nadeesha Hopefully I've addressed your feedback, thanks for reviewing! I just wanted to check about the integration test; |
|
@nadeesha hey, sorry I appreciate you're probably busy but I'd love to get this finished off if you get a moment 😁 No worries if you don't get a chance to look at it though. Have a nice weekend! |
nadeesha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sauntimo Excellent. I just took a look and almost everything looks great.
I saw however that the integration tests are failing. Could you kindly look into that, and we can merge it right after?
|
Oh, that's embarrassing! Thanks for pointing that out, I'll see if can fix this over the weekend. |
|
@nadeesha I think I've fixed the integration test now. I noticed that the generated |
|
🎉 This PR is included in version 0.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@sauntimo Thanks for addressing the feedback. This is now merged. |
|
@nadeesha awesome - thanks for your patience & help with it! |
Background
.test.ts) whereby matching source files would be ignored when determining if code is dead.Changes
-s --skip [regexp]flag which allows users to specify a pattern for source files to ignoregetPotentiallyUnusedto ensure that it's working with and without a skip pattern