Skip to content

Convert actions to Enum - #90

Merged
dgarros merged 3 commits into
mainfrom
dga-fix-86
Jan 21, 2022
Merged

Convert actions to Enum#90
dgarros merged 3 commits into
mainfrom
dga-fix-86

Conversation

@dgarros

@dgarros dgarros commented Jan 7, 2022

Copy link
Copy Markdown
Contributor

fixes #86

Technically it's not a real enum because using when using an enum the value doesn't translate directly to a string but I think the result is the same.

@dgarros
dgarros requested a review from glennmatthews as a code owner January 7, 2022 21:28
Comment thread diffsync/enum.py Outdated
glennmatthews
glennmatthews previously approved these changes Jan 21, 2022
Comment thread diffsync/helpers.py Outdated
@dgarros

dgarros commented Jan 21, 2022

Copy link
Copy Markdown
Contributor Author

@glennmatthews I've updated this PR to use a proper Enum, ready to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants