Fix caching of task ext properties with the strict parser #6696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #6695
This PR updates the strict parser to collect references to
task.ext.*so that they are added to the task hash (docs).I originally thought to move the
VariableVisitorintonf-langso that it is re-used by both, but I think this visitor does a lot of unnecessary work, and I didn't want to alter the old parser too much, so I just created a separate implementation for the strict parser that is much simpler. It only collects references totask.ext.*instead of all variable references.Note to self: once we make the strict parser the default (#6643), we should revisit the runtime layer and how it handles these variable references. I think it could be simplified quite a bit.