Skip to content

Fix data race and optimize performance #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 5, 2019
Merged

Fix data race and optimize performance #183

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
64d999e
fix data race
nicksnyder Jun 5, 2019
def9780
test noallocs
nicksnyder Jun 5, 2019
f09e408
add concurrent test
nicksnyder Jun 5, 2019
4bba2c2
add race flag
nicksnyder Jun 5, 2019
23843e2
go111module on
nicksnyder Jun 5, 2019
59150d5
atomic
nicksnyder Jun 5, 2019
2b7f330
no PKG
nicksnyder Jun 5, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test noallocs
  • Loading branch information
@nicksnyder
nicksnyder committed Jun 5, 2019
commit def97809867de3ea46b268bb7fde24039f0747af
13 changes: 11 additions & 2 deletions internal/template_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,14 @@ func TestExecute(t *testing.T) {
data interface{}
result string
err string
noallocs bool
}{
{
template: &Template{
Src: "hello",
},
result: "hello",
result: "hello",
noallocs: true,
},
{
template: &Template{
Expand All @@ -43,7 +45,8 @@ func TestExecute(t *testing.T) {
template: &Template{
Src: "hello {{",
},
err: "template: :1: unexpected unclosed action in command",
err: "template: :1: unexpected unclosed action in command",
noallocs: true,
},
}

Expand All @@ -56,6 +59,12 @@ func TestExecute(t *testing.T) {
if result != test.result {
t.Errorf("expected result %q; got %q", test.result, result)
}
allocs := testing.AllocsPerRun(10, func() {
_, _ = test.template.Execute(test.funcs, test.data)
})
if test.noallocs && allocs > 0 {
t.Errorf("expected no allocations; got %f", allocs)
}
})
}
}
Expand Down