Skip to content

feat: make use of Nix files to set up dev env #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joyeecheung merged 12 commits into from
Jan 17, 2026
Merged

feat: make use of Nix files to set up dev env #22

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f6543b1
feat: make use of Nix files to set up dev env
aduh95 Dec 7, 2025
3a89bf6
Update Dockerfile
aduh95 Dec 8, 2025
7534642
Use the same Nix version as the one tested by GHA
aduh95 Dec 8, 2025
885db6b
fix PATH
aduh95 Dec 8, 2025
cfde596
add `direnv` and `USE_SHARED_LIBS` arg
aduh95 Dec 9, 2025
b7b5eed
fixup! move ARG down to avoid needlesly invalidate cache
aduh95 Dec 9, 2025
a8c190f
squash! also use vendored ICU
aduh95 Dec 9, 2025
6b487ff
Add comments
aduh95 Dec 19, 2025
5686fcf
fixup! Add comments
aduh95 Dec 20, 2025
7f78042
fix quoting in `install-node`
aduh95 Dec 24, 2025
17b2b04
add `IMAGE_VARIANT` build var
aduh95 Dec 24, 2025
b429723
Apply suggestions from code review
aduh95 Jan 13, 2026
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
squash! also use vendored ICU
  • Loading branch information
@aduh95
aduh95 committed Dec 9, 2025
commit a8c190f3fb557ccd239a149cc3be145f5645ea2e
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ RUN echo 'eval "$(direnv hook bash)"' >> /home/developer/.bashrc

# Setting up direnv for the local clone
ARG USE_SHARED_LIBS=false
RUN echo "use nix --impure -I nixpkgs=/home/developer/nodejs/node/tools/nix/pkgs.nix$([ "${USE_SHARED_LIBS}" = "true" ] || echo " --arg sharedLibDeps '{}'")" > /home/developer/nodejs/node/.envrc
RUN echo "use nix --impure -I nixpkgs=/home/developer/nodejs/node/tools/nix/pkgs.nix$([ "${USE_SHARED_LIBS}" = "true" ] || echo " --arg sharedLibDeps '{}' --argstr icu full")" > /home/developer/nodejs/node/.envrc
Comment thread
aduh95 marked this conversation as resolved.
Outdated
Comment thread
joyeecheung marked this conversation as resolved.
Outdated
RUN direnv allow /home/developer/nodejs/node

RUN /home/developer/scripts/build.sh
Expand Down