This repository was archived by the owner on Sep 2, 2023. It is now read-only.

doc: first pass at minimal-kernel - #180

Merged

MylesBorins merged 6 commits into

nodejs:masterfrom

MylesBorins:minimal-kernel

Oct 3, 2018

MylesBorins commented Sep 12, 2018

Contributor

Decided to submit this as a PR to comment and land as documentation.

Thoughts?

MylesBorins force-pushed the minimal-kernel branch from 6569081 to 2cb7451 Compare

September 12, 2018 20:22

MylesBorins mentioned this pull request

Managing fork and agreed upon minimal kernel #166

Closed

This comment was marked as off-topic.

Sign in to view

MylesBorins force-pushed the minimal-kernel branch from 2cb7451 to 6f3f5c9 Compare

September 12, 2018 20:44


          doc: first pass at minimal-kernel

a40b8a9

Refs: nodejs#166

MylesBorins force-pushed the minimal-kernel branch from 6f3f5c9 to a40b8a9 Compare

September 12, 2018 21:54

MylesBorins commented Sep 12, 2018

Contributor Author

updated based on feedback.

Biggest changes

expand minimal kernel
- added dynamic import
- added import.meta.url
documented PRs that implement the kernel

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view


          Edit of minimal kernel doc (#2)

aa9a20b

* Rewrite: emphasize that minimal kernel is just the first phase of a multistage process, add more features and more links to features, use complete sentences.

MylesBorins commented Sep 20, 2018

Contributor Author

Updated significantly based on feedback I received from @GeoffreyBooth

As such I'm dismissing all current reviews. PTAL

MylesBorins dismissed stale reviews from mcollina and guybedford

September 20, 2018 19:47

Significant changes since review

This comment was marked as off-topic.

Sign in to view

GeoffreyBooth commented Sep 20, 2018

Member

Rich-formatted version: https://github.com/nodejs/modules/blob/aa9a20b1812901d4d858dd7bb556a736ed95b2a6/doc/plan-for-new-modules-implementation.md

Thanks @MylesBorins

SMotaal commented Sep 21, 2018

Amazing!

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

MylesBorins added the modules-agenda label

MylesBorins mentioned this pull request

Node.js Foundation Modules Team Meeting 2018-09-26 #187

Closed

SimenB mentioned this pull request

[babel-jest] mjs files jestjs/jest#4637

Closed

MylesBorins added a commit to nodejs/ecmascript-modules that referenced this pull request


          esm: remove .js support

7e5aba7

Refs: nodejs/modules#180

devsnek pushed a commit to nodejs/ecmascript-modules that referenced this pull request


          esm: remove .node support

8b65be5

Refs: nodejs/modules#180

PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

devsnek pushed a commit to nodejs/ecmascript-modules that referenced this pull request


          esm: remove .js support

2e283ec

Refs: nodejs/modules#180

PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

devsnek pushed a commit to nodejs/ecmascript-modules that referenced this pull request


          esm: remove node specifier resolution algorithm

8e3433e

Refs: nodejs/modules#180

PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

devsnek pushed a commit to nodejs/ecmascript-modules that referenced this pull request


          esm: remove .json support

2e83ce8

Refs: nodejs/modules#180

PR-URL: #6
Reviewed-By: Myles Borins <MylesBorins@google.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

devsnek pushed a commit to nodejs/ecmascript-modules that referenced this pull request


          esm: remove .node support

89e220d

Refs: nodejs/modules#180

PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

devsnek pushed a commit to nodejs/ecmascript-modules that referenced this pull request


          esm: remove .js support

453d9e3

Refs: nodejs/modules#180

PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

devsnek pushed a commit to nodejs/ecmascript-modules that referenced this pull request


          esm: remove node specifier resolution algorithm

77a022a

Refs: nodejs/modules#180

PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

devsnek pushed a commit to nodejs/ecmascript-modules that referenced this pull request


          esm: remove .json support

1869d52

Refs: nodejs/modules#180

PR-URL: #6
Reviewed-By: Myles Borins <MylesBorins@google.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

devsnek pushed a commit to nodejs/ecmascript-modules that referenced this pull request


          esm: remove .node support

682fed6

Refs: nodejs/modules#180

PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

devsnek pushed a commit to nodejs/ecmascript-modules that referenced this pull request


          esm: remove .js support

eb251aa

Refs: nodejs/modules#180

PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

devsnek pushed a commit to nodejs/ecmascript-modules that referenced this pull request


          esm: remove node specifier resolution algorithm

6ab6680

Refs: nodejs/modules#180

PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

devsnek pushed a commit to nodejs/ecmascript-modules that referenced this pull request


          esm: remove node specifier resolution algorithm

Refs: nodejs/modules#180

PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

porsager mentioned this pull request

output mithril, stream and ospec esm versions on build - fixes #2112 MithrilJS/mithril.js#2194

Merged

11 tasks

MylesBorins pushed a commit to nodejs/ecmascript-modules that referenced this pull request


          esm: remove .json support

a8ac35c

Refs: nodejs/modules#180

PR-URL: #6
Reviewed-By: Myles Borins <MylesBorins@google.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

MylesBorins added a commit to nodejs/ecmascript-modules that referenced this pull request


          esm: remove .node support

d822a1e

Refs: nodejs/modules#180

PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

MylesBorins added a commit to nodejs/ecmascript-modules that referenced this pull request


          esm: remove .js support

85cf202

Refs: nodejs/modules#180

PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

MylesBorins added a commit to nodejs/ecmascript-modules that referenced this pull request


          esm: remove node specifier resolution algorithm

39d66ab

Refs: nodejs/modules#180

PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

MylesBorins pushed a commit to MylesBorins/node that referenced this pull request


          esm: remove .json support

e1544cc

Refs: nodejs/modules#180

PR-URL: nodejs/ecmascript-modules#6
Reviewed-By: Myles Borins <MylesBorins@google.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

MylesBorins added a commit to MylesBorins/node that referenced this pull request


          esm: remove .node support

4938fec

Refs: nodejs/modules#180

PR-URL: nodejs/ecmascript-modules#6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

MylesBorins added a commit to MylesBorins/node that referenced this pull request


          esm: remove .js support

2cc5e29

Refs: nodejs/modules#180

PR-URL: nodejs/ecmascript-modules#6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

MylesBorins added a commit to MylesBorins/node that referenced this pull request


          esm: remove node specifier resolution algorithm

436ab26

Refs: nodejs/modules#180

PR-URL: nodejs/ecmascript-modules#6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

MylesBorins pushed a commit to nodejs/ecmascript-modules that referenced this pull request


          esm: remove .json support

a2b6c35

Refs: nodejs/modules#180

PR-URL: #6
Reviewed-By: Myles Borins <MylesBorins@google.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

MylesBorins added a commit to nodejs/ecmascript-modules that referenced this pull request


          esm: remove .node support

1938e00

Refs: nodejs/modules#180

PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

MylesBorins added a commit to nodejs/ecmascript-modules that referenced this pull request


          esm: remove .js support

ae5b4c6

Refs: nodejs/modules#180

PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

MylesBorins added a commit to nodejs/ecmascript-modules that referenced this pull request


          esm: remove node specifier resolution algorithm

b384a14

Refs: nodejs/modules#180

PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

nodejs-ci pushed a commit to nodejs/ecmascript-modules that referenced this pull request


          esm: remove .json support

05f32e5

Refs: nodejs/modules#180

PR-URL: #6
Reviewed-By: Myles Borins <MylesBorins@google.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

nodejs-ci pushed a commit to nodejs/ecmascript-modules that referenced this pull request


          esm: remove .node support

0fe7f7c

Refs: nodejs/modules#180

PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

nodejs-ci pushed a commit to nodejs/ecmascript-modules that referenced this pull request


          esm: remove .js support

583d692

Refs: nodejs/modules#180

PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

nodejs-ci pushed a commit to nodejs/ecmascript-modules that referenced this pull request


          esm: remove node specifier resolution algorithm

c04d037

Refs: nodejs/modules#180

PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

nodejs-ci pushed a commit to nodejs/ecmascript-modules that referenced this pull request


          esm: remove .json support

647de7f

Refs: nodejs/modules#180

PR-URL: #6
Reviewed-By: Myles Borins <MylesBorins@google.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet