Skip to content

src: revert removal of SecureContext _external getter #21711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dyatlov wants to merge 5 commits into from
Closed

src: revert removal of SecureContext _external getter #21711

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5e141fb
src: revert removal of SecureContext `_external` getter
dyatlov Jul 8, 2018
3eded9f
src: revert removal of SecureContext `_external` getter
dyatlov Jul 8, 2018
c263367
fixed external pointer conversion
dyatlov Jul 8, 2018
9b68085
Update node_crypto.cc to match current master
SirAnthony Oct 9, 2018
27376a3
Merge branch 'master' into master
SirAnthony Oct 9, 2018
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update node_crypto.cc to match current master
  • Loading branch information
@SirAnthony
SirAnthony authored Oct 9, 2018
commit 9b6808547b5a2ac12befcdc7dbcd8da8a3e44b99
3 changes: 2 additions & 1 deletion src/node_crypto.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,8 @@ void SecureContext::Initialize(Environment* env, Local<Object> target) {
Local<FunctionTemplate>(),
static_cast<PropertyAttribute>(ReadOnly | DontDelete));

target->Set(secureContextString, t->GetFunction());
target->Set(secureContextString,
t->GetFunction(env->context()).ToLocalChecked());
env->set_secure_context_constructor_template(t);
}

Expand Down