test: mark some flakes - #23208
Merged
Merged
Conversation
refack
added
test
Contributor
Author
|
https://ci.nodejs.org/job/node-test-pull-request/17571/ /CC @nodejs/testing If this passes CI I would like to fast-track. Please upvote if you approve. |
addaleax
approved these changes
Oct 2, 2018
jasnell
approved these changes
Oct 2, 2018
benjamingr
approved these changes
Oct 2, 2018
refack
force-pushed
the
batch-of-flakes
branch
from
October 2, 2018 14:48
df8e78e to
4ad3454
Compare
Contributor
Author
joyeecheung
approved these changes
Oct 2, 2018
joyeecheung
approved these changes
Oct 2, 2018
BridgeAR
approved these changes
Oct 2, 2018
Contributor
Author
|
Ci shows 1 new arm flake |
PR-URL: nodejs#23208 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
refack
force-pushed
the
batch-of-flakes
branch
from
October 2, 2018 17:13
7d07886 to
1d56ad0
Compare
Contributor
Author
|
Fast-track landed in 1d56ad0 with 5 Approvals and 3 explicit up-votes. |
targos
pushed a commit
that referenced
this pull request
Oct 3, 2018
PR-URL: #23208 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Oct 10, 2018
This was referenced Oct 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parallel:
test-net-connect-options-port: PASS,FLAKY
sequential:
test-gc-http-client-timeout: PASS, FLAKY
test-gc-http-client: PASS,FLAKY
test-gc-net-timeout: PASS,FLAKY
test-gc-http-client-onerror: PASS,FLAKY
test-gc-http-client-connaborted: PASS,FLAKY
and update some references
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes