test: remove eslint-disable from fixtures - #23345
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Fixture files are not linted. Remove `eslint-disable` comments from fixture files.
nodejs-github-bot
added
the
test
Member
Author
Trott
added
the
fast-track
richardlau
approved these changes
Oct 9, 2018
cjihrig
approved these changes
Oct 9, 2018
refack
approved these changes
Oct 9, 2018
trivikr
approved these changes
Oct 9, 2018
vsemozhetbyt
approved these changes
Oct 9, 2018
vsemozhetbyt
added
the
author ready
Member
Author
|
Landed in c001ba6 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Oct 9, 2018
Fixture files are not linted. Remove `eslint-disable` comments from fixture files. PR-URL: nodejs#23345 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Contributor
|
Would it make sense to lint fixtures as well? |
targos
pushed a commit
that referenced
this pull request
Oct 10, 2018
Fixture files are not linted. Remove `eslint-disable` comments from fixture files. PR-URL: #23345 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
This was referenced Oct 10, 2018
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
Fixture files are not linted. Remove `eslint-disable` comments from fixture files. PR-URL: #23345 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixture files are not linted. Remove
eslint-disablecomments fromfixture files.
👍 here to fast-track
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes