Skip to content

build: enable -DV8_ENABLE_CHECKS flag #61327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 6 commits into from
Jan 28, 2026
Merged

build: enable -DV8_ENABLE_CHECKS flag #61327

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
53c7e04
build: enable -DV8_ENABLE_CHECKS flag
islandryu Jan 9, 2026
7cdc3a3
fix lint
islandryu Jan 9, 2026
3a222f8
fix set_configuration_variable_and_defines
islandryu Jan 10, 2026
6847a41
Update lib/util.js
islandryu Jan 10, 2026
ed19665
validate frameCount is an integer
islandryu Jan 10, 2026
8541332
use options.debug for branching
islandryu Jan 13, 2026
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix lint
  • Loading branch information
@islandryu
islandryu committed Jan 25, 2026
commit 7cdc3a3f817536ef5eac0d0785affd167bbad4c3
2 changes: 1 addition & 1 deletion configure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1985,7 +1985,7 @@ def configure_v8(o, configs):
release='0',
debug='1'
)

o['variables']['v8_enable_webassembly'] = 0 if options.v8_lite_mode else 1
o['variables']['v8_enable_javascript_promise_hooks'] = 1
o['variables']['v8_enable_lite_mode'] = 1 if options.v8_lite_mode else 0
Expand Down
3 changes: 2 additions & 1 deletion lib/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ const {
Error,
ErrorCaptureStackTrace,
FunctionPrototypeBind,
MathFloor,
NumberIsSafeInteger,
ObjectDefineProperties,
ObjectDefineProperty,
Expand Down Expand Up @@ -458,7 +459,7 @@ function getCallSites(frameCount = 10, options) {
return mapCallSite(binding.getCallSites(frameCount));
}

frameCount = Math.floor(frameCount);
frameCount = MathFloor(frameCount);
return binding.getCallSites(frameCount);
Copy link
Copy Markdown
Member

@anonrig anonrig Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
frameCount = MathFloor(frameCount);
return binding.getCallSites(frameCount);
return binding.getCallSites(MathFloor(frameCount));
Copy link
Copy Markdown
Member

@Renegade334 Renegade334 Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is experimental, would it make more sense to switch to validateInteger?
Copy link
Copy Markdown
Member Author

@islandryu islandryu Jan 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, I switched to validateInteger to limit it to integers.
};

Expand Down