build: aix: deoptimise implementation-visitor to avoid segfault#61550
Merged
sxa merged 1 commit intonodejs:mainfrom Jan 30, 2026
Merged
build: aix: deoptimise implementation-visitor to avoid segfault#61550sxa merged 1 commit intonodejs:mainfrom
sxa merged 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Member
Author
|
Note: A build with |
Collaborator
Collaborator
Member
Author
|
(Force push before anyone reviews it in order to fix a typo in the commit message) |
richardlau
approved these changes
Jan 27, 2026
Member
richardlau
left a comment
richardlau
left a comment
There was a problem hiding this comment.
I am wondering if it is more technically correct to put these in cflags_cc but based on other existing usages in the same gyp file and that it has been tested to work LGTM.
Collaborator
Member
Author
|
Re-running test-macos GHA as first one failued |
cjihrig
approved these changes
Jan 28, 2026
Member
Author
|
Landed in 3fbb8b7 |
aduh95
pushed a commit
that referenced
this pull request
Feb 2, 2026
PR-URL: #61550 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Feb 2, 2026
PR-URL: #61550 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
sxa
added a commit
to sxa/node
that referenced
this pull request
Feb 9, 2026
PR-URL: nodejs#61550 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Feb 10, 2026
PR-URL: #61550 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Feb 14, 2026
PR-URL: #61550 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Feb 22, 2026
PR-URL: #61550 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building node.js with
--sharedon AIX thetorqueexecution consistently fails with a segmentation fault. This has been tracked down by a change in the v20 timeframe when V8 was updated to 11.3.244.4 but at an initial cursory glance it's not immediately clear which change caused it.By experimentation (by other teams I have spoken to and extra work by myself) it has also been observed that dropping the optimisation level from
-O3to-O1on one source file reliably prevents the crash from occurring. Just to be clear, this problem does not occur on the non-shared library build therefore this change reduces the optimisation only for the shared build and only on AIX.It is hoped that with this change we can reactivate the node-test-commit-aix-shared-lib job and maybe even add in the additional testing being proposed under #61463 in the future.