Skip to content

android: support cross-compiling#63061

Open
moluopro wants to merge 16 commits into
nodejs:mainfrom
moluopro:main
Open

android: support cross-compiling#63061
moluopro wants to merge 16 commits into
nodejs:mainfrom
moluopro:main

Conversation

@moluopro

@moluopro moluopro commented May 1, 2026

Copy link
Copy Markdown
Contributor

Changes

  • Support Android cross-compilation.
  • Document Android static archive output.

I’ve tested it on my local device, and it compiles successfully.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/build
  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/tsc
  • @nodejs/v8-update
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. dependencies Pull requests that update a dependency file. doc Issues and PRs related to the documentations. gyp Issues and PRs related to the GYP tool and .gyp build files libuv Issues and PRs related to the libuv dependency or the uv binding. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. zlib Issues and PRs related to the zlib subsystem. labels May 1, 2026
Comment thread .github/workflows/test-android.yml Outdated
@anonrig

anonrig commented May 1, 2026

Copy link
Copy Markdown
Member

cc @nodejs/build

@codecov

codecov Bot commented May 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.63%. Comparing base (80e0f14) to head (5339f96).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #63061      +/-   ##
==========================================
- Coverage   89.65%   89.63%   -0.02%     
==========================================
  Files         708      712       +4     
  Lines      220413   220498      +85     
  Branches    42275    42285      +10     
==========================================
+ Hits       197607   197644      +37     
- Misses      14658    14705      +47     
- Partials     8148     8149       +1     

see 45 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
moluopro added 15 commits July 2, 2026 04:08
Signed-off-by: moluopro <moluopro@qq.com>
Signed-off-by: moluopro <moluopro@qq.com>
Signed-off-by: moluopro <moluopro@qq.com>
Signed-off-by: moluopro <moluopro@qq.com>
Signed-off-by: moluopro <moluopro@qq.com>
Signed-off-by: moluopro <moluopro@qq.com>
Signed-off-by: moluopro <moluopro@qq.com>
Signed-off-by: moluopro <moluopro@qq.com>
Signed-off-by: moluopro <moluopro@qq.com>
Signed-off-by: moluopro <moluopro@qq.com>
Signed-off-by: moluopro <moluopro@qq.com>
Signed-off-by: moluopro <moluopro@qq.com>
Signed-off-by: moluopro <moluopro@qq.com>
Signed-off-by: moluopro <moluopro@qq.com>
The Android make generator needs Darwin-specific host archive and link
commands when cross-compiling on macOS.

Keep the default Android make command template unchanged and select
the Darwin host variant only while generating Android Makefiles on
macOS.

Signed-off-by: moluopro <moluopro@qq.com>
Signed-off-by: moluopro <moluopro@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. dependencies Pull requests that update a dependency file. doc Issues and PRs related to the documentations. gyp Issues and PRs related to the GYP tool and .gyp build files libuv Issues and PRs related to the libuv dependency or the uv binding. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. zlib Issues and PRs related to the zlib subsystem.

4 participants