crypto: fix warnings in test_node_crypto.cc

[MayaLekova]

Fix build warnings by casting the number literals to the size_t constants they are compared against.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/73618/

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.33%. Comparing base (49dcaa0) to head (c05b73b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #63490   +/-   ##
=======================================
  Coverage   90.33%   90.33%           
=======================================
  Files         730      730           
  Lines      234362   234362           
  Branches    43906    43919   +13     
=======================================
  Hits       211713   211713           
+ Misses      14371    14370    -1     
- Partials     8278     8279    +1     

see 21 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/73623/

[MayaLekova]

@joyeecheung can I re-run the failing tests somehow? E.g. this one looks like flaky test.
Otherwise, is it possible for you to merge the branch?

[joyeecheung]

With only one approval this could only land after 7 days since the PR is opened. Trying to see if anyone else is interested in reviewing it...cc @nodejs/cpp-reviewers

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/73702/

[MayaLekova]

I'm looking at some of the Git errors in one of the failing builds:

fatal: No rebase in progress?
[...]
git@github.com: Permission denied (publickey).
fatal: Could not read from remote repository.```

Is that because I rebased the branch from the GitHub interface?

[joyeecheung]

To keep the PR branch up-to-date with main, in Node.js we use git rebase rather than git merge https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#step-9-discuss-and-update

I think you will need to rebase onto the main branch with git rebase main -i and get rid of the second merge commit, then force push to your PR branch.

[MayaLekova]

Thanks, Joyee @joyeecheung ! I thought using the UI does rebasing indeed. Fixed things from the command line, similar to what you suggested.

Can I re-trigger the CI myself? I don't think I can edit the labels (probably due to lack of committer status).

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/73749/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/73784/

[MayaLekova]

Again the CI didn't retrigger for some reason, even after Joyee added the request-ci label.
@joyeecheung or @Aditi-1400 could you give a hand?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/73852/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/73861/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/73878/

[nodejs-github-bot]

Landed in f234f0d