Skip to content

benchmark: remove old alias usage in ffi benchmarks#63666

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
addaleax:ffi-benchmark-fix
Jun 1, 2026
Merged

benchmark: remove old alias usage in ffi benchmarks#63666
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
addaleax:ffi-benchmark-fix

Conversation

@addaleax

Copy link
Copy Markdown
Member

Follow-up to df09b2a.

Refs: #63482

Follow-up to df09b2a.

Refs: nodejs#63482
Signed-off-by: Anna Henningsen <anna@addaleax.net>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/performance
@addaleax addaleax added benchmark Issues and PRs related to the benchmark subsystem. ffi Issues and PRs related to experimental Foreign Function Interface support. labels May 30, 2026
Comment thread benchmark/ffi/add-f64.js Outdated
Comment thread benchmark/ffi/getpid.js Outdated
Comment thread benchmark/ffi/many-args.js Outdated
Comment thread benchmark/ffi/pointer-bigint.js Outdated
Comment thread benchmark/ffi/sum-buffer.js Outdated
Comment thread benchmark/ffi/add-i32.js Outdated
Co-authored-by: Mert Can Altin <mertgold60@gmail.com>
Co-authored-by: Anna Henningsen <github@addaleax.net>
@H4ad H4ad added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jun 1, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 1, 2026
@nodejs-github-bot nodejs-github-bot merged commit 7af433b into nodejs:main Jun 1, 2026
38 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 7af433b

aduh95 pushed a commit that referenced this pull request Jun 18, 2026
Follow-up to df09b2a.

Refs: #63482
Signed-off-by: Anna Henningsen <anna@addaleax.net>
PR-URL: #63666
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

benchmark Issues and PRs related to the benchmark subsystem. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. ffi Issues and PRs related to experimental Foreign Function Interface support.

6 participants