Skip to content

Conversation

@UlisesGascon
Copy link
Member

Hi all!

I am not very sure about how to manage the translations with the latests changes, but I am happy to update the spanish version for this change as well in this PR or in a separate one.

Regarding the pure content changes, let's see if there are at least 2 more members of the @nodejs/security that can review it before we merge it. 😉

We discuss to include this references in nodejs/security-wg#932

@UlisesGascon UlisesGascon requested a review from a team as a code owner March 31, 2023 07:40
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

For translations, check TRANSLATION.md!

@ovflowd ovflowd added the fast-track Fast Tracking PRs label Mar 31, 2023
@ovflowd
Copy link
Member

ovflowd commented Mar 31, 2023

Hey team, can we fast-track this PR? @nodejs/website

Copy link
Contributor

@shanpriyan shanpriyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@ovflowd
Copy link
Member

ovflowd commented Apr 1, 2023

We need one more sign-off from @nodejs/security

Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
@RafaelGSS
Copy link
Member

We need one more sign-off

That's fine. I think we can land it.

@ovflowd ovflowd merged commit f295fdd into nodejs:main Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

8 participants