[new release] qbf (0.3) #17956
Merged
[new release] qbf (0.3) #17956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
maelvls
force-pushed
the
release-qbf-0.3
branch
2 times, most recently
from
268eb02 to
e110d60
Compare
CHANGES: All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog][Keep a Changelog] and this project adheres to [Semantic Versioning][Semantic Versioning]. ## [Unreleased] ## [0.3][] - 2021-01-11 ### Added - Moved to [Dune](https://github.com/ocaml/dune) which has become the de-facto OCaml build tool. We were previously using Oasis, which was using Ocamlbuild under the hood and made the builds slightly slower. ### Removed - `depqbf` support has been temporarily removed due to the move to Dune. A PR to re-introduce `depqbf` in Dune would be welcome! ### Changed - OCaml 4.08.x is now the minimum version required to run this library. ### Fixed - Fixed the `x86_64` build on Windows + Cygwin64 + the mingw64 toolchain. - Fixed building ocaml-qbf using opam 2. Opam 2 is sandboxing builds and do not accept messing with /tmp. ## [0.2][] - 2016-06-09 ### Added - ocaml-qbf is now [available on opam](https://opam.ocaml.org/packages/qbf)! You can install it with: ```sh opam install qbf ``` ### Changed - Updated picosat to version [960](http://fmv.jku.at/picosat/) - Updated quantor to version [3.2](http://fmv.jku.at/quantor/) ### Fixed - The library can now be cross-compiled on Cygwin64 and Cygwin32 using the `x86_64-w64-mingw32` toolchain. - The macOS build was also fixed. [Keep a Changelog]: https://keepachangelog.com/ [Semantic Versioning]: https://semver.org/ [Unreleased]: c-cube/ocaml-qbf@0.3...HEAD [0.3]: https://github.com/c-cube/ocaml-qbf/compare/0.2..0.3 [0.2]: https://github.com/c-cube/ocaml-qbf/releases/0.2
maelvls
force-pushed
the
release-qbf-0.3
branch
from
e110d60 to
31e13d0
Compare
|
Build failed for an older version of Should I send a PR to fix the 3.4.1 opam file of opam-repository/packages/touist/touist.3.4.1/opam Lines 37 to 38 in ee6fb10 Should have I put instead: ? |
kit-ty-kate
reviewed
Jan 11, 2021
packages/qbf/qbf.0.3/opam
Outdated
| build: [ | ||
| ["dune" "build" "-p" name "-j" jobs] | ||
| ["dune" "build" "@doc" "-p" name ] {with-doc} | ||
| ["dune" "runtest" "-p" name "-j" jobs] {with-test & ocaml:version < "4.11"} |
There was a problem hiding this comment.
What's the reason behind not testing on 4.11? I couldn't find anything in c-cube/ocaml-qbf#7
There was a problem hiding this comment.
Not sure, @c-cube might know more about that 😅
There was a problem hiding this comment.
ok, let's try. I'll remove my change if there is an issue
There was a problem hiding this comment.
It seems to be passing without any issues. Could you return the fix upstream?
There was a problem hiding this comment.
Will do!
Done in c-cube/ocaml-qbf#11
|
All green. Thanks! |
maelvls
added a commit
to c-cube/ocaml-qbf
that referenced
this pull request
Jan 20, 2021
@kit-ty-kate has successfully been able to use --with-test [1]. [1]: ocaml/opam-repository#17956 (comment)
c-cube
pushed a commit
to c-cube/ocaml-qbf
that referenced
this pull request
Jan 20, 2021
@kit-ty-kate has successfully been able to use --with-test [1]. [1]: ocaml/opam-repository#17956 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES:
0.3 - 2021-01-11
Added
de-facto OCaml build tool. We were previously using Oasis, which was
using Ocamlbuild under the hood and made the builds slightly slower.
Removed
depqbfsupport has been temporarily removed due to the move to Dune. APR to re-introduce
depqbfin Dune would be welcome!Changed
Fixed
x86_64build on Windows + Cygwin64 + the mingw64 toolchain.do not accept messing with /tmp.