Defer XCompose reloads from migrations - #9568
Open
rookepoole wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stop the legacy XCompose migration from restarting fcitx5 while graphical applications are running.
The migration still repairs every supported Omarchy 3 include and preserves the user's custom compose sequences. The updated configuration is picked up at the next graphical login. This avoids invalidating XIM objects retained by X11 clients such as Steam, which can otherwise crash later when they create another input context.
The manual
omarchy-restart-xcomposecommand is unchanged for users who explicitly choose a live reload.Closes #9541
Test plan
bash -n migrations/1788102906.sh test/shell.d/legacy-power-udev-rules-migration-test.sh./test/shell.d/legacy-power-udev-rules-migration-test.sh./test/all(changed test passes; suite retains five unrelated baseline failures: three require anomarchy-pkgscheckout, plus the existing launch-about and network-QR assertions)Related work
PR #9282 changes the XCompose include layout for sandboxed applications. If it lands, its migration should likewise leave live input-method reloads to an explicit user action or the next graphical login.