Skip to content

Revert "Revert "Generate semconv/v1.40.0"" - #7985

Merged
pellared merged 8 commits into
mainfrom
revert-7978-revert-7929-gen_semconv_1_40
Mar 3, 2026
Merged

Revert "Revert "Generate semconv/v1.40.0""#7985
pellared merged 8 commits into
mainfrom
revert-7978-revert-7929-gen_semconv_1_40

Conversation

@MrAlias

@MrAlias MrAlias commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

Reverts #7978

@MrAlias MrAlias added this to the v1.42.0 milestone Mar 2, 2026
@MrAlias MrAlias changed the title Revert "Revert "Generate semconv/v1.40.0"": Add semconv/v1.40.0 Mar 2, 2026
@MrAlias
MrAlias marked this pull request as ready for review March 2, 2026 19:13
Copilot AI review requested due to automatic review settings March 2, 2026 19:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Re-introduces the go.opentelemetry.io/otel/semconv/v1.40.0 package (reverting a prior revert) by adding generated semantic-convention code and updating release notes.

Changes:

  • Adds generated v1.40.0 semantic convention packages (including multiple *conv metric helpers).
  • Adds core v1.40.0 semconv package files (schema URL, exception consts, docs, error-type helper + tests).
  • Updates CHANGELOG.md to announce the new semconv version.

Reviewed changes

Copilot reviewed 25 out of 30 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
semconv/v1.40.0/signalrconv/metric.go Adds generated SignalR metric instruments and attribute helpers for v1.40.0.
semconv/v1.40.0/schema.go Declares v1.40.0 SchemaURL constant for the semconv package.
semconv/v1.40.0/rpcconv/metric.go Adds generated RPC metric instruments and attribute helpers for v1.40.0.
semconv/v1.40.0/processconv/metric.go Adds generated process metric instruments and attribute helpers for v1.40.0.
semconv/v1.40.0/messagingconv/metric.go Adds generated messaging metric instruments and attribute helpers for v1.40.0.
semconv/v1.40.0/mcpconv/metric.go Adds generated MCP metric instruments and attribute helpers for v1.40.0.
semconv/v1.40.0/goconv/metric.go Adds generated Go runtime metric instruments and attribute helpers for v1.40.0.
semconv/v1.40.0/genaiconv/metric.go Adds generated GenAI metric instruments and attribute helpers for v1.40.0.
semconv/v1.40.0/faasconv/metric.go Adds generated FaaS metric instruments and attribute helpers for v1.40.0.
semconv/v1.40.0/exception.go Adds the exception event name constant in the v1.40.0 semconv package.
semconv/v1.40.0/error_type_test.go Adds tests validating the new ErrorType helper behavior.
semconv/v1.40.0/error_type.go Adds an ErrorType(err) helper for producing error.type attributes.
semconv/v1.40.0/doc.go Adds package-level docs for semconv/v1.40.0.
semconv/v1.40.0/dnsconv/metric.go Adds generated DNS metric instruments and attribute helpers for v1.40.0.
semconv/v1.40.0/cicdconv/metric.go Adds generated CI/CD metric instruments and attribute helpers for v1.40.0.
semconv/v1.40.0/azureconv/metric.go Adds generated Azure metric instruments and attribute helpers for v1.40.0.
semconv/v1.40.0/README.md Adds a short README for the v1.40.0 semconv package.
semconv/v1.40.0/MIGRATION.md Adds migration notes for upgrading to semconv v1.40.0.
CHANGELOG.md Announces addition of the semconv/v1.40.0 package.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread semconv/v1.40.0/dnsconv/metric.go
Comment thread semconv/v1.40.0/rpcconv/metric.go
Comment thread semconv/v1.40.0/MIGRATION.md
Comment thread CHANGELOG.md Outdated
Comment thread semconv/v1.40.0/error_type.go
@codecov

codecov Bot commented Mar 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.7%. Comparing base (3310435) to head (ff28758).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #7985     +/-   ##
=======================================
- Coverage   81.7%   81.7%   -0.1%     
=======================================
  Files        304     304             
  Lines      23337   23337             
=======================================
- Hits       19081   19080      -1     
- Misses      3867    3868      +1     
  Partials     389     389             

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@pellared
pellared merged commit 5dee2eb into main Mar 3, 2026
33 of 34 checks passed
@pellared
pellared deleted the revert-7978-revert-7929-gen_semconv_1_40 branch March 3, 2026 06:32
pellared added a commit that referenced this pull request Mar 6, 2026
### Added

- Add `go.opentelemetry.io/otel/semconv/v1.40.0` package.
The package contains semantic conventions from the `v1.40.0` version of
the OpenTelemetry Semantic Conventions.
See the [migration documentation](./semconv/v1.40.0/MIGRATION.md) for
information on how to upgrade from
`go.opentelemetry.io/otel/semconv/v1.39.0`. (#7985)
- Add `Err` and `SetErr` on `Record` in `go.opentelemetry.io/otel/log`
to attach an error and set record exception attributes in
`go.opentelemetry.io/otel/log/sdk`. (#7924)

### Changed

- `TracerProvider.ForceFlush` in `go.opentelemetry.io/otel/sdk/trace`
joins errors together and continues iteration through SpanProcessors as
opposed to returning the first encountered error without attempting
exports on subsequent SpanProcessors. (#7856)

### Fixed

- Fix missing `request.GetBody` in
`go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp` to
correctly handle HTTP2 GOAWAY frame. (#7931)
- Fix semconv v1.39.0 generated metric helpers skipping required
attributes when extra attributes were empty. (#7964)
- Preserve W3C TraceFlags bitmask (including the random Trace ID flag)
during trace context extraction and injection in
`go.opentelemetry.io/otel/propagation`. (#7834)

### Removed

- Drop support for [Go 1.24]. (#7984)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants