fix(sdk): preserve canceled scan state - #735
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
![chatgpt-codex-connector[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 53a8c9f052
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 67afadc3ba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
Fixes #44. When a caller cancels a registered SDK scan, the scan history is
currently finalized with
fail-scan, so an intentional cancellation is storedas a failure instead of a cancellation.
Changes
ScanInterruptedErrorvalues throughcancel-scan.fail-scanfor ordinary failures, internal tracking failures, andScanCostLimitExceededErrorso those errors retain their message and costmetadata.
arguments for a canceled scan.
Testing
bun test --timeout 30000 tests-ts/api.test.ts— 139 passed, 2 skipped, 0 failed.bun test --timeout 30000 tests-ts/scan-recovery.test.ts— 40 passed, 0 failed.pnpm --ignore-workspace run lint— passed.pnpm --ignore-workspace --dir ../../plugins/codex-security/mcp-app run typecheck— passed.pnpm --ignore-workspace run generate:models:check— passed.pnpm --ignore-workspace run format— passed.git diff --check— passed.Risk and rollout
This changes only the persisted lifecycle command for explicit caller/client
cancellation. Ordinary failures and cost-limit recovery retain the existing
failure path and metadata. No public API or scan input contract changes.
Public disclosure review