fix(deep-scan): remove coverage from aggregation - #767
Open
daneschneider-oai wants to merge 10 commits into
Open
fix(deep-scan): remove coverage from aggregation#767daneschneider-oai wants to merge 10 commits into
daneschneider-oai wants to merge 10 commits into
Conversation
daneschneider-oai
marked this pull request as ready for review
September 1, 2026 00:23
Collaborator
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 28e6e82d14
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deep scans combine several independent reviews. A scan can reach its stopping point and still be labeled partial because one worker left notes about unfinished work. That makes the final status confusing: it reflects one worker's notes instead of whether the Deep scan finished.
Completion follows the scan's stopping rules, and reducers focus on combining findings. The report includes the configured directories and exclusions, and the host supplies
coverage.jsonfor existing readers.Changes
coveragefrom reducer tool inputs, returned inputs, saved results, checkpoints, and prompts. Ignore coverage in older saved reducer results when resuming.surfaces,explicitExclusions, anddeferredarrays, and noopenQuestions. Standard workers keep their original coverage.Testing
Risk and rollout
The reducer contract changes; canonical output schemas stay compatible. Existing readers still use the host-generated
coverage.json, including completeness for status and comparisons. Successful Deep reports omit worker/reducer coverage observations.Configured scope exclusions, Standard/diff behavior, stop thresholds, no-review time-limit diagnostics, and stopped-scan findings recovery remain supported. No version bump.
Public disclosure review