test(sdk): isolate fixtures from ambient umask - #775
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 507f23a56c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2b9268da8d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
mldangelo-oai
left a comment
There was a problem hiding this comment.
Thanks for tracking this down and iterating on the review feedback! The final fixture-only fix keeps the production permission checks intact. I independently verified 23 focused tests across the nine changed files under both 0002 and 0022, including the unsafe-parent cases. Looks good to merge once CI passes.
Summary
Fixes #207.
Several POSIX tests treat directories they create as trusted/private fixtures but inherited the invoking account umask. Under
0002, those directories became0775and were correctly rejected by the SDK secure-ancestry checks. This change gives only those test-owned fixtures an explicit private mode without relaxing production validation or changing process-global state.Changes
0700Testing
pnpm run types— passpnpm run format— passgit diff --check— passThe current tree also exposes separate low-umask failures in post-start scan flows. This patch deliberately does not chmod or otherwise repair those product-created ancestors, so those failures remain visible for separate diagnosis.
Risk and rollout
Test-only change. It does not install a preload, mutate the runner umask, alter product-created paths, or change production behavior. POSIX mode normalization is skipped where appropriate on Windows.
Public disclosure review