Next hop group attribute to specify if weights are achieved by repeating members or via the weighting support in the hardware.. - #2166
Conversation
…ogrammed by repeating the next hop members in proportion to their weight or by using the intrinsic next hop group weight support in the hardware. Signed-off-by: Kishore Gummadidala <kishorg@google.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rck-innovium
left a comment
rck-innovium
left a comment
There was a problem hiding this comment.
Need more understanding so as to standardize the expected behavior.
| * | ||
| * @type bool | ||
| * @flags CREATE_AND_SET | ||
| * @default false |
There was a problem hiding this comment.
The default value of "false" will NOT be backward compatible for devices that support Native WCMP.
The name of this attribute must be SAI_NEXT_HOP_GROUP_ATTR_DISABLE_NATIVE_WCMP with default value as False.
There was a problem hiding this comment.
@erohsik Kishore, Can you please add comment that NOS should query this attribute as supported or not.
And only if supported then we should make the default as true i.e. native WECP.
If platform doesn't support this attribute then WECMP works just the way today it is.
|
|
||
| /** | ||
| * @brief Weighted multi path configuration mode. | ||
| * false: Nexthop group is programmed with repeated member entries proportional to their weight |
There was a problem hiding this comment.
When the SAI implementation repeats next hop group member entries, should the SAI_SWITCH_ATTR_AVAILABLE_NEXT_HOP_GROUP_MEMBER_ENTRY attribute be updated to reflect the count of the repeated entries, or should it be based on the number of unique members in the ASIC_DB?
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@erohsik - could you please help address the comments? |
JaiOCP
left a comment
JaiOCP
left a comment
There was a problem hiding this comment.
Approving with the suggested comments
| * | ||
| * @type bool | ||
| * @flags CREATE_AND_SET | ||
| * @default false |
There was a problem hiding this comment.
@erohsik Kishore, Can you please add comment that NOS should query this attribute as supported or not.
And only if supported then we should make the default as true i.e. native WECP.
If platform doesn't support this attribute then WECMP works just the way today it is.
6 participants
Add new next hop group attribute to specify if a next hop group is programmed by repeating the next hop members in proportion to their weight or by using the intrinsic next hop group weight support in the hardware.