[debugcounter] Add support for SAI_IN_DROP_REASON_EGRESS_LINK_DOWN - #2333
Merged
tjchadaga merged 1 commit intoAug 31, 2026
Merged
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
tsmail1441
force-pushed
the
add-egress-link-down-drop-reason
branch
from
August 18, 2026 22:02
9506661 to
6f00183
Compare
kcudnik
requested changes
Aug 18, 2026
tsmail1441
force-pushed
the
add-egress-link-down-drop-reason
branch
from
August 18, 2026 23:31
6f00183 to
fb31455
Compare
kcudnik
reviewed
Aug 19, 2026
tsmail1441
force-pushed
the
add-egress-link-down-drop-reason
branch
from
August 19, 2026 20:55
fb31455 to
01535dc
Compare
Extend the `sai_in_drop_reason_t` enum with `SAI_IN_DROP_REASON_EGRESS_LINK_DOWN` to support tracking packets dropped at ingress when the target egress port/interface is down. While `SAI_IN_DROP_REASON_L3_EGRESS_LINK_DOWN` specifically targets routed (L3) packets, certain ASIC architectures and pipelines drop traffic at ingress whenever the destination egress link is down regardless of packet type, or do not distinguish between L2 and L3 drops for this condition. Adding `SAI_IN_DROP_REASON_EGRESS_LINK_DOWN` enables debug counters to generically capture egress link down drops across both L2 (bridged) and L3 (routed) traffic. Change-Id: Ifb3b440f79f0eacccb6138b4d02410dcb0d02ebd Signed-off-by: Tommy Smail <tommysmail@google.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
| * Generic counter across all forwarding pipelines when the resolved egress link is down. | ||
| * e.g.: L2 bridging, L3 routing, tunnels | ||
| */ | ||
| SAI_IN_DROP_REASON_EGRESS_LINK_DOWN, |
There was a problem hiding this comment.
SAI_OUT_DROP_REASON_L3_EGRESS_LINK_DOWN already exists in sai_out_drop_reason_t. If an ASIC reports egress-link-down drops on the egress side without L2/L3 distinction,, can you consider adding a generic SAI_OUT_DROP_REASON_EGRESS_LINK_DOWN in this PR?
kcudnik
approved these changes
Aug 27, 2026
JaiOCP
approved these changes
Aug 27, 2026
JaiOCP
left a comment
JaiOCP
left a comment
Contributor
There was a problem hiding this comment.
No need to deprecate the L3 drop counter. NOS can query the capability..
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
tjchadaga
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extend the
sai_in_drop_reason_tenum withSAI_IN_DROP_REASON_EGRESS_LINK_DOWNto support tracking packets dropped at ingress when the target egress port/interface is down.Motivation
While
SAI_IN_DROP_REASON_L3_EGRESS_LINK_DOWNspecifically targets routed (L3) packets, certain ASIC architectures and pipelines drop traffic at ingress whenever the destination egress link is down regardless of packet type, or do not distinguish between L2 and L3 drops for this condition.Adding
SAI_IN_DROP_REASON_EGRESS_LINK_DOWNenables debug counters to generically capture egress link down drops across both L2 (bridged) and L3 (routed) traffic.Changes
inc/saidebugcounter.hto addSAI_IN_DROP_REASON_EGRESS_LINK_DOWNtosai_in_drop_reason_t.Signed-off-by: Tommy Smail tommysmail@google.com