Skip to content

LOG-6333: Fix supported OpenShift versions #2856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

xperimental
Copy link
Contributor

@xperimental xperimental commented Oct 30, 2024

Description

Fixes the supported OpenShift versions for version 6.1

/cc @cahartma
/assign @jcantrill

Links

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 30, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 30, 2024

@xperimental: This pull request references LOG-6333 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.8.0" version, but no target version was set.

In response to this:

Description

Fixes the supported OpenShift versions for version 6.1

/cc @cahartma
/assign @jcantrill

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 30, 2024

@xperimental: This pull request references LOG-6333 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.8.0" version, but no target version was set.

In response to this:

Description

Fixes the supported OpenShift versions for version 6.1

/cc @cahartma
/assign @jcantrill

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the midstream/Dockerfile A Dockerfile.in sync is needed with midstream label Oct 30, 2024
Copy link
Contributor

openshift-ci bot commented Oct 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xperimental

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2024
Copy link
Contributor

@jcantrill jcantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 30, 2024
@jcantrill
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2024
@xperimental xperimental force-pushed the supported-versions-6.1 branch from aff96cd to 898e574 Compare November 1, 2024 13:13
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2024
@jcantrill
Copy link
Contributor

/test e2e-target

@xperimental
Copy link
Contributor Author

/override e2e-target

@xperimental
Copy link
Contributor Author

I might not have the power to do that 🙂

Copy link
Contributor

openshift-ci bot commented Nov 4, 2024

@xperimental: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • e2e-target

Only the following failed contexts/checkruns were expected:

  • ci/prow/ci-index-cluster-logging-operator-bundle
  • ci/prow/e2e-target
  • ci/prow/functional-target
  • ci/prow/images
  • ci/prow/lint
  • ci/prow/unit
  • ci/prow/upgrade
  • pull-ci-openshift-cluster-logging-operator-master-ci-index-cluster-logging-operator-bundle
  • pull-ci-openshift-cluster-logging-operator-master-e2e-target
  • pull-ci-openshift-cluster-logging-operator-master-functional-target
  • pull-ci-openshift-cluster-logging-operator-master-images
  • pull-ci-openshift-cluster-logging-operator-master-lint
  • pull-ci-openshift-cluster-logging-operator-master-unit
  • pull-ci-openshift-cluster-logging-operator-master-upgrade
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override e2e-target

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jcantrill
Copy link
Contributor

/override ci/prow/e2e-target

@jcantrill
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2024
Copy link
Contributor

openshift-ci bot commented Nov 4, 2024

@jcantrill: Overrode contexts on behalf of jcantrill: ci/prow/e2e-target

In response to this:

/override ci/prow/e2e-target

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Nov 4, 2024

@xperimental: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@xperimental
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit f3983f4 into openshift:master Nov 5, 2024
8 checks passed
@xperimental xperimental deleted the supported-versions-6.1 branch November 5, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. midstream/Dockerfile A Dockerfile.in sync is needed with midstream release/6.1
3 participants