prometheus-node-exporter-ucode: add nat_traffic collector#29705
prometheus-node-exporter-ucode: add nat_traffic collector#29705ricardnacher wants to merge 1 commit into
Conversation
ricardnacher
force-pushed
the
prometheus-node-exporter-ucode-nat-traffic
branch
from
fd8f965 to
b494294
Compare
|
Hi, just a friendly ping — this PR has been open for a couple of weeks. Would appreciate a review when you have a moment, and happy to make any changes if needed. Thanks! @GeorgeSapkin |
ricardnacher
force-pushed
the
prometheus-node-exporter-ucode-nat-traffic
branch
from
b494294 to
3ca7f8a
Compare
|
Hi @GeorgeSapkin, I fixed the signed-off name by amending the commit. Is there anything else needed before it can be reviewed? thanks |
|
I'm neither a maintainer, nor a user of this package, so I don't have an opinion about this PR. At the very least, |
BKPepe
force-pushed
the
prometheus-node-exporter-ucode-nat-traffic
branch
from
6f0655f to
38c330f
Compare
I am sorry, thanks! |
|
@ricardnacher can you fix the formalities please @dhewg ping |
ricardnacher
force-pushed
the
prometheus-node-exporter-ucode-nat-traffic
branch
2 times, most recently
from
96259d5 to
2f00592
Compare
Add a nat_traffic collector for prometheus-node-exporter-ucode, ported from the equivalent Lua collector in prometheus-node-exporter-lua. Reads /proc/net/nf_conntrack and exports per-(src, dst) pair byte totals (both directions summed) as node_nat_traffic gauge metrics. Also includes a ucode-based unit test with a fixture file that can be run locally with: ucode test/nat_traffic.uc Signed-off-by: Ricard Nacher <ricard.nacher@midokura.com>
ricardnacher
force-pushed
the
prometheus-node-exporter-ucode-nat-traffic
branch
from
2f00592 to
a696219
Compare
done! |
3 participants
Maintainer: @dhewg
Summary
nat_trafficcollector toprometheus-node-exporter-ucode, ported from the equivalent Lua collector inprometheus-node-exporter-lua/proc/net/nf_conntrackand exports per-(src, dst)pair byte totals (both directions summed) asnode_nat_trafficgauge metricstest/nat_traffic.uc) for local development testingTest plan
ucode test/nat_traffic.uc(3/3 assertions)test.shhandlesprometheus-node-exporter-ucode-nat_trafficpackage variant; skips gracefully if/proc/net/nf_conntrackis absentnode_nat_traffic) and label schema (src,dst)Signed-off-by: ricardnacher ricard.nacher@midokura.com