Skip to content

[android] Add Silence Music option for TTS #11533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[android] Add Silence Music option for TTS #11533

wants to merge 1 commit into from

Conversation

@AndrewShkrob
Copy link
Member

Closes: #5109
@AndrewShkrob AndrewShkrob requested a review from a team as a code owner October 13, 2025 13:47
@AndrewShkrob AndrewShkrob added the Android Android development label Oct 13, 2025
@AndrewShkrob
[android] Add Silence Music option for TTS
704ed50 
Signed-off-by: Andrei Shkrob <github@shkrob.dev>
@AndrewShkrob AndrewShkrob force-pushed the android/tts-silence-music branch from a2de42d to 704ed50 Compare October 13, 2025 14:01
biodranik
biodranik approved these changes Oct 13, 2025
View reviewed changes
Copy link
Member

@biodranik biodranik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely silencing the music for each direction announcement is very, very annoying:

  1. "Turn left in 2km".
  2. After some seconds "turn left in 200m".
  3. After a few seconds "turn left, and then turn right"
  4. After a few seconds "turn right"

It was not fully clear why ducking doesn't work in the referenced issue. If ducking works, then the driver clearly hears the instruction, and it is not as super annoying, because the music is still heard, but quieter than normally.

Adding a silence option instead of fixing the non-working ducking looks like a костыль to me, that doesn't fix the root cause, and adds a bad workaround.
biodranik
biodranik requested changes Oct 13, 2025
View reviewed changes
Copy link
Member

@biodranik biodranik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong approve button, sorry. Let's investigate why ducking doesn't work before merging this.
@AndrewShkrob
Copy link
Member Author

@biodranik Are you sure you got the PR right?

Screen.Recording.2025-10-13.at.17.01.452.mov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Android Android development

2 participants

@AndrewShkrob @biodranik