Copilot adds extra closing quotes to completions

[wesbos]

Select Topic Area

Bug

Body

Seems dozens of people having this issue: https://twitter.com/wesbos/status/1628458196967751681

I've been experiencing it for about 3-4 weeks.

If I open a quote in VS code, it opens the closing one. Then copilot ignores the closing quote and add it's own.

Example:

Any fix for this? Very annoying. Apparently also happening with parenthesis. Will add screenshots as I hit them.

[calag4n]

Also with ) , }, ]

[iamcjwilliams]

@wesbos Thank you for your feedback, our copilot team has been notified!

[wesbos]

awesome! thank you!

[karolis-kimtys]

Does not do this all the time, but when it does, it is slightly annoying.

[johnson-alan]

Happens intermittently (given the stochastic nature of these LLMs presumably), so my pattern-matching brain can't learn to anticipate it and correct for it:

[DianomiJH]

I've also been getting this, an additional case being

I've already closed the quotes and it's recommended that I close them again

[NickMaczk]

I'm getting extra brackets when I validate a suggestion inside brackets.

[Billycarter1224]

I am also facing this issue. Please fix it if someone solved it.

[joehillen]

https://medium.com/coding-at-dawn/make-github-copilot-way-better-with-these-two-vs-code-settings-842775ba82f7

[wesbos]

not a great solution, then we lose this functionality for the entire editor. I hope this is just fixed in co-pilot

[wesbos]

With the announcement of Github copilot x today, I think this is fixed! I'm on nightly, can anyone confirm for stable?

[KonstantinosPetrakis]

I am still getting it right now.

[patosullivan]

I use copilot.vim, still seeing this issue.

[wesbos]

I was wrong, this is still an issue. Even the AI knows to remove them.

Getting very annoying - any word on this? Are you aware of the bug at least?

[luke396]

Can I politely ask, what is the page provided in your screenshot where you can talk (copilot chat maybe)?

[Stephanie-Spears]

I'm curious, too

[wesbos]

This is Raycast - a desktop app uses GPT-3.5 for chat. Though I am testing Copilot X chat and its even better for this stuff

[wesbos]

BTW we had @mattrothenberg on our podcast, and while he doesn't work on Copilot any longer, he said hes aware of the bug too. Hopefully we will hear some sort of confirmation from the team soon.

[drusepth]

Just to bump this and confirm this is still an issue -- I'm still seeing this in August, 2023, almost always adding } to close all open scopes.

[pyronaur]

+1

Side note: This isn't an issue in WebStorm - so it should be doable in VSCode too!

[Stephanie-Spears]

Not sure if this is accurate since it was a while ago, but I think I may have mistyped extra quotes on one of the first completion lines I accepted. Had me wondering if all the code suggestions thereafter were using that initial mistake as a baseline...seems unlikely that the AI would get stumped by something like that, though. ¯\(ツ)/¯

[isidorn]

Hi, VS Code PM here 👋 @hediet has fixed this issue 🎉
It should be included in the Copilot extension release in October. Once it is released, I will comment here again so you can try it out and let us know if there are still cases that are missing. fyi @hsenag

Thanks all 🙏

[wesbos]

Yeah It seems to not happen on fresh files, but as soon as the file has a few lines in it, it starts to happen consistently. In practice, it seems about 20% of the use cases were fixed. Amazon Code Whisperer does not have the same issue since their build 1.97.0 2023-11-02

[hsenag]

@dnicolson thanks - it happens sometimes for me with that example. We'll see what we can do to fix it.

[wesbos]

Another two examples. Let me know if I should keep posting them.

Kapture.2023-11-10.at.11.50.03.mp4

Code for this one:

async function getFile(filePath: string) {
  if (cache.has(filePath)) {
    console.log(`[CACHE] ${filePath}`);
    console.log({ cache });
    return cache.get(filePath);
  }

  const file = (await import(filePath)) as { default: string };
  cache.set(filePath, file.default);
  return file.default;
}

[hsenag]

@wesbos They are useful - I can't promise immediate fixes but I have spent a few hours this afternoon on @dnicolson 's one so they're not just disappearing into the ether.

[ian-h-chamberlain]

I've run into this case somewhat frequently with Rust #[attributes], particularly with parentheses. Example:

https://github.com/rust3ds/citro3d-rs/blob/c56c4cdfed331355d0f4cf305487116dcfa25a37/citro3d/src/lib.rs#L121

In that case #[doc()] brackets were completed by VSCode, but Copilot still suggested an additional parenthesis. This seems to happen maybe 50-75% of the time for me.

Copilot version v1.138.0, in case that's relevant. Hope these reports are still useful.

[wesbos]

Still seems to be an issue, and maybe reverted? See it with console.log and most methods that need a string

[Superskyyy]

Still a major ux issue after a year :(

[xixixao]

Isn't there a simple, but imperfect fix? Take the suggestion from copilot, compare it to what's after the cursor, and strip out anything that matches from the end.

There will be scenarios in which too much is stripped, especially if the punctuation is already imbalanced, but I think those will be rarer and easier to fix than the super annoying status quo.

@wesbos (thank you for fighting the good fight), @hsenag @hediet @isidorn @idan

Bonus points: Sometimes copilot also suggests trailing semicolon which is usually not yet typed, so consider that being present if there's a new line or end of file.

[tpope]

Pre-release 1.152.662 should contain fixes to most if not all of the duplicate bracket/quote bugs reported in this discussion.

[wesbos]

Not sure if this was covered, but multi-line backtick strings still add an extra

[ajwootto]

I experience a lot of these issues in Jetbrains IDE as well. Is it also going to be fixed there?

[tpope]

The big fix from last week was common to all plugins and has landed in stable releases of Copilot for VS Code (1.153.0+), JetBrains (1.4.12.4386+), and Vim/Neovim (1.16.0+).

There's still a few multi-line edge cases; hopefully will have more to report soon. ✔️

[wesbos]

Thank you @tpope! i've been very happy with it since this. Ill mark as fixed!

[tpope]

Pre-release 1.155.677 has a fix for multi-line issues like the one with the JavaScript backtick string above. This too will make its way into upcoming stable releases of all editor plugins.