fix: defer bitsandbytes import until use - #441
Open
motodriver wants to merge 1 commit into
Open
Conversation
Assisted-by: TRAE
p-e-w
requested changes
Sep 1, 2026
| import unittest | ||
|
|
||
|
|
||
| class ModelImportTests(unittest.TestCase): |
Owner
There was a problem hiding this comment.
Get rid of this test, it doesn't tell us anything. It simply asserts that the import line that has been moved has indeed been moved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bitsandbytesimportbitsandbytesonly when a quantized weight actually requires 4-bit dequantizationbitsandbytesimport while loadingheretic.modelThis prevents an unrelated bitsandbytes native-library traceback from being emitted at startup for non-BNB use while preserving the existing failure behavior when 4-bit dequantization is actually required.
Fixes #429.
Verification
uv run --frozen python -m unittest discover -s tests -p "test_*.py"— 5 passeduv run --frozen ruff format --check .uv run --frozen ruff check --output-format=github --extend-select I .uv run --frozen ty check --output-format=github --error-on-warning .git diff --checkAI assistance from TRAE was used for repository analysis, test drafting, and review. I reviewed the complete diff and ran the verification above.