Skip to content

(chore) Migrate /datetime to vitest pt3 - sinon mocks conversion#7828

Open
cameronjoyner wants to merge 6 commits intocj/datetime-vitest-2from
cj/datetime-vitest-3
Open

(chore) Migrate /datetime to vitest pt3 - sinon mocks conversion#7828
cameronjoyner wants to merge 6 commits intocj/datetime-vitest-2from
cj/datetime-vitest-3

Conversation

@cameronjoyner
Copy link
Contributor

@cameronjoyner cameronjoyner commented Feb 27, 2026

FLUP to (chore) Migrate /datetime to vitest pt2 - vitest usage
Similar to [chore]: Replace sinon with vitest in core tests

What this accomplishes

Converts sinon mocks to vitest standard

Note

This only converts assert to expect where absolutely necessary. Otherwise thats coming in a FLUP PR.

Next steps

  1. Convert assertions: assert to expect
  2. Update test descriptions to BDD-style "should..."
  3. Migrate individual tests from Enzyme to RTL (one at a time)
@changelog-app
Copy link

changelog-app bot commented Feb 27, 2026

Generate changelog in packages/datetime/changelog/@unreleased

Type (Select exactly one)

  • Feature (Adding new functionality)
  • Improvement (Improving existing functionality)
  • Fix (Fixing an issue with existing functionality)
  • Break (Creating a new major version by breaking public APIs)
  • Deprecation (Removing functionality in a non-breaking way)
  • Migration (Automatically moving data/functionality to a new system)

Description

(chore) Migrate /datetime to vitest pt3 - sinon mocks conversion

Check the box to generate changelog(s)

  • Generate changelog entry
@cameronjoyner cameronjoyner changed the base branch from develop to cj/datetime-vitest-2 February 27, 2026 17:18
@svc-palantir-github
Copy link

scaffolding

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@cameronjoyner cameronjoyner marked this pull request as ready for review February 27, 2026 17:33
@svc-palantir-github
Copy link

Merge branch 'cj/datetime-vitest-2' into cj/datetime-vitest-3

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@svc-palantir-github
Copy link

formatting

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@svc-palantir-github
Copy link

adding type MockInstance,

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants