[lint]: Use oxlint for import cycle checks to cut CI lint time#7835
Open
[lint]: Use oxlint for import cycle checks to cut CI lint time#7835
Conversation
7d45345 to
39029c8
Compare
Disable ESLint import cycle detection and enable through oxlintBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI lint was taking ~20 minutes, mostly due to the ESLint rule
import/no-cyclefromeslint-plugin-import, which is expensive in ESLint’s per-file model. This PR moves cycle detection to Oxlint, which does it via multi-file analysis and finishes in seconds, while keeping the rest of lint in ESLint.Changes
import/no-cycleis now always off (no longer run only in CI).lint:cyclesscript that runs only the import cycle rule overpackages/.pnpm lint, the lint job runspnpm lint:cyclesso cycles are still enforced..oxlintrc.jsonenables the import plugin andimport/no-cyclewith ignore patterns aligned to ESLint (node_modules, dist, lib, etc.).Result
Before (ESLint import/no-cycle enabled in CI): Lint ~18m 31s, total pipeline ~27m 15s
After (oxlint for cycle detection): Lint ~1m 2s, total pipeline ~15m 9s
Verification
Cycle detection was checked with temporary test files. A minimal example that correctly fails
pnpm lint:cycles:Within a package (e.g.
packages/colors/src/):Across packages (core ↔ colors):