TST: troubleshoot flaky linux plotting tests#64317
Open
jbrockmendel wants to merge 9 commits intopandas-dev:mainfrom
Open
TST: troubleshoot flaky linux plotting tests#64317jbrockmendel wants to merge 9 commits intopandas-dev:mainfrom
jbrockmendel wants to merge 9 commits intopandas-dev:mainfrom
Conversation
mroeschke
reviewed
Feb 26, 2026
Member
mroeschke
left a comment
mroeschke
left a comment
There was a problem hiding this comment.
I would be fine passing a fairly generous tolerance to the assertion functions just to be safe. AFAICT this keyword is mostly just passed through to Matplotlib?
Member
Author
|
Updated to allow a small tolerance. |
mroeschke
reviewed
Mar 1, 2026
pandas/tests/plotting/test_series.py
Outdated
| # GH#64317 on some linux builds this is flaky with the first entry being | ||
| # off by -1.69e-21. Rather than xfail this test, we allow a small | ||
| # tolerance, as it isn't really user-visible. | ||
| tm.assert_almost_equal(result, expected, atol=2e-21) |
Member
There was a problem hiding this comment.
Given that the expecteds only is as small as 1e-5, could we bump the atol to like 1e-15 to give us more wiggle room? Just want to rule out floating point artifacts biting us again here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed strict=False xfail-on-linux in 4 places to see if they have magically resolved themselves.