Add option to translate the mobile menu title#551
Open
BlueFox4 wants to merge 1 commit intopanr:masterfrom
Open
Add option to translate the mobile menu title#551BlueFox4 wants to merge 1 commit intopanr:masterfrom
BlueFox4 wants to merge 1 commit intopanr:masterfrom
Conversation
|
The similar variable By the way, I've fixed this "issue" in earlier PR (#543), so you can upvote it to proceed with merge. |
Author
|
Yes, I saw this PR before, but at least for me the following strings weren't the exact same thing:
That's why I introduced the I guess maybe something in the middle would be perfect; what I would suggest:
Would that make sense to you? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the option to translate the mobile menu title (which was hard-coded to 'Menu' before) by setting the
$.Site.Params.menuTitlevariable. If this is not done - nothing changes, nothing breaks.Something missing? Please tell me!