Skip to content

Add Missing Pack Items - #1345

Merged
arielkr256 merged 2 commits into
releasefrom
ben/pack-fix-2
Sep 10, 2024
Merged

arielkr256 merged 2 commits into
releasefrom
ben/pack-fix-2

Conversation

@ben-githubs

Copy link
Copy Markdown
Contributor

Background

Some of our packs were missing items, mainly subrules that are used in correlation rules, and queries attached to scheduled rules. This PR should fix any that weren't present before!

The issue was originally raised here.

Changes

  • Added missing items to pack manifests

Testing

  • I updated my pack checking script to look for queries and correlation sub-rules. I spot checked about half the results and confirmed they are correct.
@ben-githubs
ben-githubs requested a review from a team as a code owner September 6, 2024 18:45
@github-actions

github-actions Bot commented Sep 6, 2024

Copy link
Copy Markdown

😱
looks like some things could be wrong with the packs

[INFO][root]: ignoring file dependabot.yml
@arielkr256
arielkr256 enabled auto-merge (squash) September 10, 2024 14:23
@arielkr256
arielkr256 merged commit 0147335 into release Sep 10, 2024
@arielkr256
arielkr256 deleted the ben/pack-fix-2 branch September 10, 2024 14:25
@arielkr256 arielkr256 added the bug Something isn't working label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

2 participants