Skip to content

[fix] Make Google drive rules app name specific - #2037

Merged
arielkr256 merged 2 commits into
developfrom
fix-rules
May 1, 2026
Merged

arielkr256 merged 2 commits into
developfrom
fix-rules

Conversation

@alessandrarizzo

Copy link
Copy Markdown
Contributor

Background

Changes

Testing

@alessandrarizzo
alessandrarizzo requested a review from a team as a code owner April 22, 2026 14:36
@alessandrarizzo alessandrarizzo added the tuning detection tuning label Apr 22, 2026
@cursor

cursor Bot commented Apr 22, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Small, targeted filter change to rule matching plus test updates; main risk is unintentionally missing events if some Drive logs lack id.applicationName.

Overview
Tightens two Google Workspace ActivityEvent detections to only trigger when id.applicationName is drive, preventing false positives from similarly named actions in other Google apps.

Updates the associated rule tests to include the Drive applicationName field on positive/negative cases and adds explicit negative test coverage for Gmail events.

Reviewed by Cursor Bugbot for commit f3026b0. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2c4c685. Configure here.

Comment thread rules/gsuite_activityevent_rules/gsuite_drive_many_docs_deleted.py
@arielkr256
arielkr256 added this pull request to the merge queue May 1, 2026
Merged via the queue into develop with commit f8f6886 May 1, 2026
18 checks passed
@arielkr256
arielkr256 deleted the fix-rules branch May 1, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tuning detection tuning

2 participants