AI overhaul - #2049
Merged
Merged
AI overhaul#2049
Conversation
PR SummaryCursor Bugbot is generating a summary for commit b9e8ae0. Configure here. |
| - `pat test` runs unit tests defined in the `.yml` `Tests:` block. It does **not** make network calls and does not validate against a live Panther instance. | ||
| - **Correlation rules cannot be fully tested with `pat test`.** Use `pat validate` against a Panther instance — see [`style_guides/CORRELATION_RULES_STYLE_GUIDE.md`](style_guides/CORRELATION_RULES_STYLE_GUIDE.md). | ||
| - When iterating on a single rule, **always** scope with `--path` or `--filter`. The full test suite is large. | ||
| - `make test` already wraps `pat test` plus the helper/data-model unit tests — prefer it as the final gate. |
Contributor
There was a problem hiding this comment.
Suggested change
| - `make test` already wraps `pat test` plus the helper/data-model unit tests — prefer it as the final gate. | |
| - `make test` already wraps `pat test` plus the helper/data-model unit tests — prefer it as the final gate. | |
| - `pat test` does not run on rules with a `Status: Experimental` marker. When developing new rules, add the Status after testing them. | |
Contributor
Author
There was a problem hiding this comment.
this is actually fixed, experimental rules get tested now!
alessandrarizzo
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Consolidates older AI agent instructions to AGENTS.md and introduces a skill for using Panther MCP to ground new detections in real log data.
Changes