Skip to content

disable correlation rules by default - #2114

Merged
arielkr256 merged 3 commits into
developfrom
disable-crs-default
Jun 26, 2026
Merged

arielkr256 merged 3 commits into
developfrom
disable-crs-default

Conversation

@arielkr256

Copy link
Copy Markdown
Contributor

Correlation rules should only be enabled if the underlying data sources are available.

@arielkr256
arielkr256 requested review from a team as code owners June 25, 2026 23:00
@cursor

cursor Bot commented Jun 25, 2026 •

Copy link
Copy Markdown

PR Summary

Medium Risk
Disabling correlation rules by default reduces detection coverage until operators re-enable them; standardized longer lookbacks and daily run rates also change when and how far back sequences are evaluated.

Overview
Sets Enabled: false on correlation rules across correlation_rules/ so they stay off until customers have the required underlying log sources and opt in.

Alongside that, detection scheduling is aligned: Schedule.RateMinutes is moved to 1440 and LookbackWindowMinutes to 1800 on the touched rules (replacing shorter per-rule intervals). Snowflake exfiltration correlation rules also use 1800 lookback instead of 2160.

Index/coverage updates drop entries for AWS Privilege Escalation Via User Compromise and AWS User Takeover Via Password Reset from indexes/alpha-index.md, indexes/aws.md, and indexes/detection-coverage.json.

Reviewed by Cursor Bugbot for commit b6bde3f. Bugbot is set up for automated code reviews on this repo. Configure here.

@arielkr256
arielkr256 enabled auto-merge June 25, 2026 23:00

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit b6bde3f. Configure here.

RateMinutes: 1440
TimeoutMinutes: 5
LookbackWindowMinutes: 30
LookbackWindowMinutes: 1800

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookback below schedule ratio minimum

Medium Severity

This change sets LookbackWindowMinutes to 1800 with RateMinutes 1440, but project guidance requires lookback at least 1.5× the run interval (2160 minutes here). That ratio avoids gaps between daily runs. The same edit also replaces attack-specific windows (e.g. OpenAI’s documented 30-minute brute-force span) with 30 hours, so re-enabling would correlate unrelated events.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit b6bde3f. Configure here.

@arielkr256
arielkr256 disabled auto-merge June 26, 2026 14:59
@arielkr256
arielkr256 merged commit d415b30 into develop Jun 26, 2026
5 checks passed
@arielkr256
arielkr256 deleted the disable-crs-default branch June 26, 2026 14:59
@arielkr256 arielkr256 added the tuning detection tuning label Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tuning detection tuning

2 participants