Skip to content
This repository was archived by the owner on Feb 28, 2023. It is now read-only.

CACHEPOT_BASEDIR - #116

Merged
Xanewok merged 6 commits into
masterfrom
fs-basedir
Dec 6, 2021
Merged

CACHEPOT_BASEDIR#116
Xanewok merged 6 commits into
masterfrom
fs-basedir

Conversation

@montekki

@montekki montekki commented Nov 11, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@montekki
montekki marked this pull request as ready for review November 30, 2021 17:35
@montekki

montekki commented Nov 30, 2021

Copy link
Copy Markdown
Contributor Author

@drahnr, marking this ready for review.

Just strip CARGO_MANIFEST_DIR from the paths, dont cache the cwd and call it a day. The testing i've done shows that it improves the cache hit rate somewhat but quite honestly I do not think that the task at hand is doable cleanly and safely for all usecases at this point.

Testing done: build cachepot with cachepot.

There still are a lot of absulute paths that end up in the build artifacts such as

  1. paths in *.d files.
  2. paths in artifacts from the cc builds
  3. paths in things that are still built locally such as cdylib crates.
drahnr
drahnr reviewed Dec 1, 2021
View reviewed changes
Comment thread src/compiler/rust.rs Outdated
@drahnr

drahnr commented Dec 3, 2021

Copy link
Copy Markdown
Contributor

A rebase and this should be good to go :)
@drahnr

drahnr commented Dec 6, 2021

Copy link
Copy Markdown
Contributor

rustfmt seems unhappy, I'd like to land this soon™ :)
@Xanewok
Xanewok enabled auto-merge (squash) December 6, 2021 14:14
@Xanewok
Xanewok merged commit 9a12040 into master Dec 6, 2021
@Xanewok
Xanewok deleted the fs-basedir branch December 6, 2021 14:21
@Xanewok Xanewok mentioned this pull request Dec 6, 2021
Closed
This was referenced Dec 6, 2021
Open
Closed
@drahnr drahnr mentioned this pull request Apr 16, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants

@montekki @drahnr @Xanewok