feat: retain cause for upload fetch errors #14987
Open
+27
−30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Ensure the cause for upload fetch errors (
error.cause) is retained so that it gets surfaced/printed at the server console.Why?
The error message for errors thrown by
fetch(e.g. network connectivity issues, SSL certificate errors, etc.) is very generic (basically "fetch failed"); the actual error message/code is inerror.cause. The current error handling for upload fetches discards the cause, making it very difficult to debug fetch errors.How?
This updates
FileRetrievalErrorto accept the error cause as a parameter (passing it as thedataparameter ofAPIError), and updates the try/catch clauses insafeFetchandgenerateFileDatato pass the error cause toFileRetrievalError.