feat: pass local API depth through to req.query.depth for consistency
#15023
+157
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: consistency with the Rest / GraphQL API. If hooks rely
on `req.query.depth`, `req: {query: {depth: x}}` would have to be
manually passed to local API calls such as `payload.find({})`, in
addition to `depth: x`. This was easy to forget, in which case the
local API calls would result in different outcomes than if the same
operation was triggered via Rest / GraphQL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: Consistency of the local API with the
reqparameter of requests made via the Rest / GraphQL API.Before this change, if hooks relied on
req.query.depth,req: {query: {depth: x}}would have to be manually passed to local API calls such aspayload.find({}), in addition todepth: x. This was easy to forget, in which case the local API calls would result in different outcomes than if the same operation was triggered via Rest / GraphQL. This was confusing.